Skip to content

Fix YouTube player volume sync and custom URL validation#148

Merged
BunsDev merged 1 commit into
mainfrom
okcode/youtube-player-error-fix
Apr 1, 2026
Merged

Fix YouTube player volume sync and custom URL validation#148
BunsDev merged 1 commit into
mainfrom
okcode/youtube-player-error-fix

Conversation

@BunsDev
Copy link
Copy Markdown
Member

@BunsDev BunsDev commented Apr 1, 2026

Summary

  • Syncs the volume slider with the actual YouTube iframe player using postMessage, including mute/unmute handling and reapplying volume on iframe load and ready events.
  • Improves the player drawer UX with clearer playlist controls, active-item indicators, tooltips, and a cleaner empty state prompt.
  • Adds inline validation and keyboard handling to the custom URL editor, including autofocus, Escape-to-cancel, and explicit error messages.
  • Adjusts the iframe sandbox and removes modestbranding from the embed URL builder.

Testing

  • Not run (not requested).
  • Expected checks: bun fmt.
  • Expected checks: bun lint.
  • Expected checks: bun typecheck.

- Apply volume changes to the embedded iframe player
- Surface validation errors in the custom URL editor
- Improve playlist controls and player affordances
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
okcode-marketing Ready Ready Preview Apr 1, 2026 4:29am

@github-actions github-actions Bot added size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 1, 2026
@BunsDev BunsDev merged commit e1294b9 into main Apr 1, 2026
8 of 9 checks passed
@BunsDev BunsDev deleted the okcode/youtube-player-error-fix branch April 1, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant